Add per_tensor overload for quantized_conv #6648
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/6648
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 1908508 with merge base 17ad8d3 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D65306801 |
hsharma35
approved these changes
Nov 5, 2024
Summary: As titled. Note that the kernel doens't support per_channel now anyway, but it will in the future so we keep both. Will remove 4 `full` ops per conv, including 2 that were completely unused. Reviewed By: dulinriley, hsharma35 Differential Revision: D65306801
facebook-github-bot
force-pushed
the
export-D65306801
branch
from
3fe2eea to
1908508
Compare
|
This pull request was exported from Phabricator. Differential Revision: D65306801 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: As titled. Note that the kernel doens't support per_channel now anyway, but it will in the future so we keep both. Will remove 4
fullops per conv, including 2 that were completely unused.Reviewed By: dulinriley
Differential Revision: D65306801